Skip to content

fix(tools): normalize tuple schemas for Gemini API#5800

Open
EaCognitive wants to merge 3 commits into
google:mainfrom
EaCognitive:fix/tuple-schema-clean
Open

fix(tools): normalize tuple schemas for Gemini API#5800
EaCognitive wants to merge 3 commits into
google:mainfrom
EaCognitive:fix/tuple-schema-clean

Conversation

@EaCognitive
Copy link
Copy Markdown

@EaCognitive EaCognitive commented May 22, 2026 •
edited
Loading

Re-opening my fix for #5428 since the original issue was closed due to inactivity from the reporter.

My previous PR (#5446) accidentally included broken cli and noxfile.py files which caused the CI failures. This is a clean submission containing ONLY the strip-based workaround verified to fix the Cloud Run deployment issues.

Testing Plan

  • Mypy-diff verified clean against main.
  • pre-commit run --all-files passes format and license checks.
  • Added 4 explicit unit tests in tests/unittests/tools/test_function_parameter_parse_util.py to verify prefixItems and unevaluatedItems are successfully recursively stripped.
  • Multi-version tests (Python 3.10-3.14) pass successfully.

Logs

$ pytest tests/unittests/tools/test_function_parameter_parse_util.py
============================= test session starts ==============================
platform darwin -- Python 3.11.15, pytest-9.0.3, pluggy-1.6.0
collected 4 items

tests/unittests/tools/test_function_parameter_parse_util.py ....         [100%]

============================== 4 passed in 0.05s ===============================

cc @surajksharma07 @rohityan

@adk-bot adk-bot added the tools [Component] This issue is related to tools label May 22, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented May 22, 2026

Response from ADK Triaging Agent

Hello @EaCognitive, thank you for reopening this clean PR to fix the Cloud Run deployment issue #5428!

While reviewing your PR against our contribution guidelines, we noticed a few items that could be added or updated to help speed up the review:

  1. Testing Plan: Please include a designated testing plan section in your PR description detailing how the changes are verified.
  2. Logs or Screenshots: For bug fixes, please provide logs or screenshots showcasing the output or verified fix to help reviewers understand the changes better.
  3. CI Status / Header Check: The CI run shows that the header-check status check has failed. Please verify that all files conform to the license header requirements. You can run the auto-formatter/linter locally using pre-commit run --all-files to automatically apply the license headers and resolve format checks.

This information will help our reviewers review your PR more efficiently. Thanks again for your contribution!

@sasha-gitg
Copy link
Copy Markdown
Collaborator

sasha-gitg commented May 22, 2026

We switched to Gemini JSON schema by default so I don't think this PR is necessary because from_function_with_options is bypassed.

@rohityan rohityan self-assigned this May 26, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rohityan rohityan

Labels

request clarification [Status] The maintainer need clarification or more information from the author tools [Component] This issue is related to tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EaCognitive @adk-bot @sasha-gitg @rohityan